Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add margin and check to AssetActionButton text #4381

Merged
merged 10 commits into from
May 24, 2022
Merged

[FIX] Add margin and check to AssetActionButton text #4381

merged 10 commits into from
May 24, 2022
+41 −13

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented May 23, 2022 •
edited
Loading

Description

The AssetActionButton component wasn't handling long string. This PR add a margin and a 10 character max check to the component to avoid UI issues

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

BUG FIX
Bug Fix

Issue

Progresses Issue Reference

@gantunesr gantunesr requested a review from a team as a code owner May 23, 2022 06:22
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 23, 2022
Fatxx
Fatxx reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be pointing to release/5.2?

app/components/UI/AssetActionButton/index.js Outdated Show resolved Hide resolved
@gantunesr
Copy link
Member Author

@Fatxx I need this in main for another development, I'll cherry pick it to the release branch

Fatxx
Fatxx reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 24, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

chrisleewilcox
chrisleewilcox approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gantunesr gantunesr merged commit 3fa1c4b into main May 24, 2022
@gantunesr gantunesr deleted the fix/5.2.0/spacing-asset-btn-text branch May 24, 2022 23:21
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gantunesr @Fatxx @chrisleewilcox @cortisiko @plasmacorral