-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @metamask/preferences-controller
to ^14.0.0
#12472
chore: bump @metamask/preferences-controller
to ^14.0.0
#12472
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Bitrise🔄🔄🔄 Commit hash: 53b4229 Note
|
53b4229
to
f43ab8e
Compare
Bitrise🔄🔄🔄 Commit hash: f43ab8e Note
|
f43ab8e
to
382b135
Compare
Bitrise✅✅✅ Commit hash: 382b135 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This does introduce a peer dependency warning, but it will not introduce an error. The warning is due to this version requiring v18 of keyring-controller, but mobile uses v17. The only difference in v18 is the removal of The warning will go away with #12339 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since there is not changes to the preferences controller source code, the patch remains the same!
Description
This PR bumps
@metamask/preferences-controller
to^14.0.0
Related issues
Fixes: #12305
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist