Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/preferences-controller to ^14.0.0 #12472

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 27, 2024

Description

This PR bumps @metamask/preferences-controller to ^14.0.0

Related issues

Fixes: #12305

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 27, 2024
Copy link

socket-security bot commented Nov 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 0 B

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 53b4229
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0047051f-2e3b-4da4-8eb4-c43305064d4c

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-preferences-controller-14.0.0 branch from 53b4229 to f43ab8e Compare November 27, 2024 17:06
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: f43ab8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6a893c28-9fcb-4aab-847b-e3c0602b6488

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-preferences-controller-14.0.0 branch from f43ab8e to 382b135 Compare November 27, 2024 17:10
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 382b135
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/612885eb-37b4-48fd-bdb0-88d7a5031604

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 27, 2024

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Nov 27, 2024

This does introduce a peer dependency warning, but it will not introduce an error. The warning is due to this version requiring v18 of keyring-controller, but mobile uses v17. The only difference in v18 is the removal of addNewAccountWithoutUpdate, which the preferences controller does not use.

The warning will go away with #12339

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since there is not changes to the preferences controller source code, the patch remains the same!

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit a7968b4 Nov 28, 2024
50 of 51 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-preferences-controller-14.0.0 branch November 28, 2024 00:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update metamask/preferences-controller to version 14.0.0
4 participants