Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: toggle the chain permissions feature flag on after #12436

Closed
wants to merge 2 commits into from

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Nov 26, 2024

Description

After having obtained the go ahead, toggle the chain permissions feature flag on.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Nov 26, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 changed the title feat: DO NOT MERGE, toggle the mutlichain feature flag on for bitris… feat: DO NOT MERGE, this PR is to check which unit tests fail Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 570f140
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6567176f-9cdb-4471-b610-b0087467dcaa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Nov 26, 2024

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@EtherWizard33 EtherWizard33 reopened this Nov 27, 2024
@EtherWizard33 EtherWizard33 changed the title feat: DO NOT MERGE, this PR is to check which unit tests fail chore: toggle the chain permissions feature flag on after Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant