Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Creating data tree for signed type V1 signatures #12393

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 22, 2024

Description

Adding data tree for typed sign V1 signature request.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3655

Manual testing steps

  1. Enable mobile re-designs locally
  2. Open test dapp and submit sign types v1 request
  3. Check page that opens

Screenshots/Recordings

Screen.Recording.2024-11-21.at.7.46.00.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Nov 22, 2024
@jpuri jpuri requested review from a team as code owners November 22, 2024 10:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 22, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3c9f18d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1f36715-1f40-46fc-a587-8d2e85e47134

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4732bf2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e96cce90-df06-4678-b1ad-a740387b6b86

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.93%. Comparing base (22a4989) to head (4732bf2).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...rmations/components/Confirm/DataTree/DataField.tsx 50.00% 1 Missing and 1 partial ⚠️
...ns/components/Confirm/Info/TypedSignV1/Message.tsx 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12393      +/-   ##
==========================================
+ Coverage   56.41%   56.93%   +0.52%     
==========================================
  Files        1797     1814      +17     
  Lines       40586    40871     +285     
  Branches     5097     5172      +75     
==========================================
+ Hits        22896    23271     +375     
+ Misses      16134    16023     -111     
- Partials     1556     1577      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 22, 2024

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants