Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @metamask/swaps-controller to ^11.0.0 #12368

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mikesposito
Copy link
Member

Description

This PR bumps @metamask/swaps-controller to ^11.0.0. See package changelog for details on changes

Related issues

Related to: #11910

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Nov 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 280 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@mikesposito mikesposito marked this pull request as ready for review November 21, 2024 11:12
@mikesposito mikesposito requested review from a team as code owners November 21, 2024 11:12
@mikesposito mikesposito self-assigned this Nov 21, 2024
@mikesposito mikesposito requested a review from a team November 21, 2024 11:14
@mikesposito mikesposito added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d1de7b6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17120551-4325-4280-b7a2-63754a9038f9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@@ -189,7 +189,7 @@
"@metamask/snaps-utils": "^8.1.1",
"@metamask/stake-sdk": "^0.2.13",
"@metamask/swappable-obj-proxy": "^2.1.0",
"@metamask/swaps-controller": "^10.0.0",
"@metamask/swaps-controller": "^11.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the changelog says it have the gas fee controller v21 as peer dependency, isn't that a blocker for this update?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like swaps-controller v10 has no peer dependency on gas-fee-controller — that was added in v11. So yes it does seem like we ought to bump gas-fee-controller first if we can.

Copy link

sonarcloud bot commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

4 participants