-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump @metamask/swaps-controller
to ^11.0.0
#12368
base: main
Are you sure you want to change the base?
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Bitrise✅✅✅ Commit hash: d1de7b6 Note
|
@@ -189,7 +189,7 @@ | |||
"@metamask/snaps-utils": "^8.1.1", | |||
"@metamask/stake-sdk": "^0.2.13", | |||
"@metamask/swappable-obj-proxy": "^2.1.0", | |||
"@metamask/swaps-controller": "^10.0.0", | |||
"@metamask/swaps-controller": "^11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the changelog says it have the gas fee controller v21 as peer dependency, isn't that a blocker for this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like swaps-controller
v10 has no peer dependency on gas-fee-controller
— that was added in v11. So yes it does seem like we ought to bump gas-fee-controller
first if we can.
Quality Gate passedIssues Measures |
Description
This PR bumps
@metamask/swaps-controller
to^11.0.0
. See package changelog for details on changesRelated issues
Related to: #11910
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist