chore: #12184 MVP split engine file

[Cal-L]

Description

This PR establishes a pattern for splitting out controllers from the main Engine.ts file, which provides the following benefits

• Reduce friction regarding code ownership especially during reviews (this is the main purpose of this effort)
• Easier to manage, test, and handling controller initialization failures

The POC here applies to the AccountsController initialization logic, which has been mostly abstracted out into AccountsController directory. This pattern should be applicable to other controllers in the Engine file as well.

This pattern also enables us to redirect users to vault recovery in the event of controller initialization failures and should reduce the chances of users being "bricked". These changes may be introduced in future interations

Related issues

Fixes: #12184

Manual testing steps

The changes should not affect app behavior

• Run the app as usual
• Ensure that everything behaves as usual (Auth, dapp connections, navigation, etc)

Screenshots/Recordings

Before

After

App still runs normally

app.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8443cc7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/897a1c5f-e79a-4635-af2f-d45d7ade7e75

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

We are not exporting via index for AccountsController here since it exposes the risk of circular dependencies (caused by action/event dependencies)

[Cal-L]

Skipping sonar failure (Engine.ts) since this PR just removes code from the file

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f69b6d3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8068757-a06a-41a0-900c-d02ca1f04e4b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate failed

Failed conditions
53.7% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

[EtherWizard33]

LGTM