-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated example envs and README #12027
base: main
Are you sure you want to change the base?
Changes from all commits
aa83fd2
52ca130
fe0970d
a0987e0
bdc4323
5e17799
a2a41ea
4b9bad3
32521bc
da0218c
5095274
b08e03a
60b846a
0d8d0bc
f09c24e
453f15f
f977e5c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>API_KEY</key> | ||
<string>mock-api-key-1234</string> | ||
<key>GCM_SENDER_ID</key> | ||
<string>mock-gcm-sender-id-1234</string> | ||
<key>PLIST_VERSION</key> | ||
<string>1</string> | ||
<key>BUNDLE_ID</key> | ||
<string>io.metamask.MetaMask</string> | ||
<key>PROJECT_ID</key> | ||
<string>mockproject-1234</string> | ||
<key>STORAGE_BUCKET</key> | ||
<string>mock-storage-bucket-1234.appspot.com</string> | ||
<key>IS_ADS_ENABLED</key> | ||
<false></false> | ||
<key>IS_ANALYTICS_ENABLED</key> | ||
<false></false> | ||
<key>IS_APPINVITE_ENABLED</key> | ||
<true></true> | ||
<key>IS_GCM_ENABLED</key> | ||
<true></true> | ||
<key>IS_SIGNIN_ENABLED</key> | ||
<true></true> | ||
<key>GOOGLE_APP_ID</key> | ||
<string>mock-google-app-id-1234</string> | ||
</dict> | ||
</plist> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>API_KEY</key> | ||
<string>$(FCM_CONFIG_API_KEY)</string> | ||
<key>GCM_SENDER_ID</key> | ||
<string>$(FCM_CONFIG_MESSAGING_SENDER_ID)</string> | ||
<key>PLIST_VERSION</key> | ||
<string>1</string> | ||
<key>BUNDLE_ID</key> | ||
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string> | ||
<key>PROJECT_ID</key> | ||
<string>$(FCM_CONFIG_PROJECT_ID)</string> | ||
<key>STORAGE_BUCKET</key> | ||
<string>$(FCM_CONFIG_STORAGE_BUCKET)</string> | ||
<key>IS_APPINVITE_ENABLED</key> | ||
<true></true> | ||
<key>IS_GCM_ENABLED</key> | ||
<true></true> | ||
<key>IS_SIGNIN_ENABLED</key> | ||
<true></true> | ||
<key>GOOGLE_APP_ID</key> | ||
<string>$(FCM_CONFIG_APP_ID)</string> | ||
</dict> | ||
</plist> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
/* Begin PBXBuildFile section */ | ||
07CBADD9D4B441008304F8D3 /* EuclidCircularB-Light.otf in Resources */ = {isa = PBXBuildFile; fileRef = A98029A3662F4C1391489A6B /* EuclidCircularB-Light.otf */; }; | ||
08B7A641467C4723B98328E9 /* CentraNo1-Medium.otf in Resources */ = {isa = PBXBuildFile; fileRef = F97653CAD1D04E1B8713C428 /* CentraNo1-Medium.otf */; }; | ||
0FD509E0336BF221F6527B24 /* BuildFile in Frameworks */ = {isa = PBXBuildFile; }; | ||
0FD509E0336BF221F6527B24 /* (null) in Frameworks */ = {isa = PBXBuildFile; }; | ||
13B07FBC1A68108700A75B9A /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB01A68108700A75B9A /* AppDelegate.m */; }; | ||
13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; }; | ||
13B07FC11A68108700A75B9A /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.m */; }; | ||
|
@@ -134,15 +134,18 @@ | |
B339FF2E289ABD70001B89FB /* EuclidCircularB-SemiboldItalic.otf in Resources */ = {isa = PBXBuildFile; fileRef = 9499B01ECAC44DA29AC44E80 /* EuclidCircularB-SemiboldItalic.otf */; }; | ||
B339FF32289ABD70001B89FB /* Branch.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 153F84C92319B8DB00C19B63 /* Branch.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; }; | ||
B339FF3C289ABF2C001B89FB /* MetaMask-QA-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = B339FEA72899852C001B89FB /* MetaMask-QA-Info.plist */; }; | ||
B638844E306CAE9147B52C85 /* BuildFile in Frameworks */ = {isa = PBXBuildFile; }; | ||
B638844E306CAE9147B52C85 /* (null) in Frameworks */ = {isa = PBXBuildFile; }; | ||
BF39E5BAE0F34F9091FF6AC0 /* EuclidCircularB-Semibold.otf in Resources */ = {isa = PBXBuildFile; fileRef = A8DE9C5BC0714D648276E123 /* EuclidCircularB-Semibold.otf */; }; | ||
C8424AE42CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = C8424AE32CCC01F900F0BEB7 /* GoogleService-Info.plist */; }; | ||
C8424AE52CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = C8424AE32CCC01F900F0BEB7 /* GoogleService-Info.plist */; }; | ||
C8424AE62CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = C8424AE32CCC01F900F0BEB7 /* GoogleService-Info.plist */; }; | ||
CD13D926E1E84D9ABFE672C0 /* Roboto-BlackItalic.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 3E2492C67CF345CABD7B8601 /* Roboto-BlackItalic.ttf */; }; | ||
CF9895772A3B49BE00B4C9B5 /* RCTMinimizer.m in Sources */ = {isa = PBXBuildFile; fileRef = CF9895762A3B49BE00B4C9B5 /* RCTMinimizer.m */; }; | ||
CF9895782A3B49BE00B4C9B5 /* RCTMinimizer.m in Sources */ = {isa = PBXBuildFile; fileRef = CF9895762A3B49BE00B4C9B5 /* RCTMinimizer.m */; }; | ||
CF98DA9C28D9FEB700096782 /* RCTScreenshotDetect.m in Sources */ = {isa = PBXBuildFile; fileRef = CF98DA9B28D9FEB700096782 /* RCTScreenshotDetect.m */; }; | ||
CFD8DFC828EDD4C800CC75F6 /* RCTScreenshotDetect.m in Sources */ = {isa = PBXBuildFile; fileRef = CF98DA9B28D9FEB700096782 /* RCTScreenshotDetect.m */; }; | ||
D171C39A8BD44DBEB6B68480 /* EuclidCircularB-MediumItalic.otf in Resources */ = {isa = PBXBuildFile; fileRef = 42CBA652072F4BE2A8B815C1 /* EuclidCircularB-MediumItalic.otf */; }; | ||
D45BF85DECACCB74EDCBE88A /* BuildFile in Frameworks */ = {isa = PBXBuildFile; }; | ||
D45BF85DECACCB74EDCBE88A /* (null) in Frameworks */ = {isa = PBXBuildFile; }; | ||
D5BA0E32DFAA451781D5093E /* CentraNo1-BoldItalic.otf in Resources */ = {isa = PBXBuildFile; fileRef = 4560812198A247039A1CF5A5 /* CentraNo1-BoldItalic.otf */; }; | ||
DADE8F39CE81410A98B9B805 /* MMSans-Regular.otf in Resources */ = {isa = PBXBuildFile; fileRef = 2EBD310362314C3ABFF40AD1 /* MMSans-Regular.otf */; }; | ||
DC6A024F56DD43E1A83B47B1 /* Roboto-MediumItalic.ttf in Resources */ = {isa = PBXBuildFile; fileRef = D5FF0FF1DFB74B3C8BB99E09 /* Roboto-MediumItalic.ttf */; }; | ||
|
@@ -302,6 +305,7 @@ | |
BCC95B62DD6241678CDF73B3 /* CentraNo1-BookItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "CentraNo1-BookItalic.otf"; path = "../app/fonts/CentraNo1-BookItalic.otf"; sourceTree = "<group>"; }; | ||
BF485CDA047B4D52852B87F5 /* EvilIcons.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = EvilIcons.ttf; path = "../node_modules/react-native-vector-icons/Fonts/EvilIcons.ttf"; sourceTree = "<group>"; }; | ||
C752564A28B44392AEE16BD5 /* Roboto-Medium.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "Roboto-Medium.ttf"; path = "../app/fonts/Roboto-Medium.ttf"; sourceTree = "<group>"; }; | ||
C8424AE32CCC01F900F0BEB7 /* GoogleService-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = "GoogleService-Info.plist"; sourceTree = "<group>"; }; | ||
C9FD3FB1258A41A5A0546C83 /* Roboto-BoldItalic.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "Roboto-BoldItalic.ttf"; path = "../app/fonts/Roboto-BoldItalic.ttf"; sourceTree = "<group>"; }; | ||
CE0434C5FB7C4C6F9FEBDCE2 /* EuclidCircularB-Medium.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "EuclidCircularB-Medium.otf"; path = "../app/fonts/EuclidCircularB-Medium.otf"; sourceTree = "<group>"; }; | ||
CF014205BB8964CFE74D4D8E /* Pods-MetaMask-QA.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-MetaMask-QA.release.xcconfig"; path = "Target Support Files/Pods-MetaMask-QA/Pods-MetaMask-QA.release.xcconfig"; sourceTree = "<group>"; }; | ||
|
@@ -337,9 +341,9 @@ | |
650F2B9D24DC5FF200C3B9C4 /* libRCTAesForked.a in Frameworks */, | ||
153C1ABB2217BCDC0088EFE0 /* JavaScriptCore.framework in Frameworks */, | ||
153F84CA2319B8FD00C19B63 /* Branch.framework in Frameworks */, | ||
0FD509E0336BF221F6527B24 /* BuildFile in Frameworks */, | ||
D45BF85DECACCB74EDCBE88A /* BuildFile in Frameworks */, | ||
B638844E306CAE9147B52C85 /* BuildFile in Frameworks */, | ||
0FD509E0336BF221F6527B24 /* (null) in Frameworks */, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These seem to be artifacts left over from removed files. Let's remove all of these null lines. |
||
D45BF85DECACCB74EDCBE88A /* (null) in Frameworks */, | ||
B638844E306CAE9147B52C85 /* (null) in Frameworks */, | ||
ED2E8FE6D71BE9319F3B27D3 /* libPods-MetaMask.a in Frameworks */, | ||
); | ||
runOnlyForDeploymentPostprocessing = 0; | ||
|
@@ -533,6 +537,7 @@ | |
83CBB9F61A601CBA00E9B192 = { | ||
isa = PBXGroup; | ||
children = ( | ||
C8424AE32CCC01F900F0BEB7 /* GoogleService-Info.plist */, | ||
2EF283352B17EC4E00D7B4B1 /* Light-Swift-Untar-V2 */, | ||
2EF283312B17EC1A00D7B4B1 /* RNTar.m */, | ||
2EF283292B17EBD600D7B4B1 /* RnTar.swift */, | ||
|
@@ -765,6 +770,7 @@ | |
EF65C42EA15B4774B1947A12 /* Roboto-Medium.ttf in Resources */, | ||
DC6A024F56DD43E1A83B47B1 /* Roboto-MediumItalic.ttf in Resources */, | ||
34CEE49BC79D411687B42FA9 /* Roboto-Regular.ttf in Resources */, | ||
C8424AE62CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */, | ||
7E08FB90F3754D47994208B4 /* Roboto-Thin.ttf in Resources */, | ||
7C0226ABD9694AEDBAF3016F /* Roboto-ThinItalic.ttf in Resources */, | ||
15ACC9FB226555820063978B /* LaunchScreen.xib in Resources */, | ||
|
@@ -819,6 +825,7 @@ | |
2EF282802B0FF86900D7B4B1 /* EuclidCircularB-BoldItalic.otf in Resources */, | ||
2EF282812B0FF86900D7B4B1 /* EuclidCircularB-Light.otf in Resources */, | ||
2EF282822B0FF86900D7B4B1 /* EuclidCircularB-LightItalic.otf in Resources */, | ||
C8424AE52CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */, | ||
2EF282832B0FF86900D7B4B1 /* EuclidCircularB-Medium.otf in Resources */, | ||
2EF282842B0FF86900D7B4B1 /* EuclidCircularB-MediumItalic.otf in Resources */, | ||
2EF282852B0FF86900D7B4B1 /* EuclidCircularB-Regular.otf in Resources */, | ||
|
@@ -840,6 +847,7 @@ | |
B339FF15289ABD70001B89FB /* Roboto-BlackItalic.ttf in Resources */, | ||
B339FF16289ABD70001B89FB /* Roboto-Bold.ttf in Resources */, | ||
B339FF17289ABD70001B89FB /* debug.xcconfig in Resources */, | ||
C8424AE42CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */, | ||
B339FF18289ABD70001B89FB /* Roboto-BoldItalic.ttf in Resources */, | ||
B339FF19289ABD70001B89FB /* Roboto-Italic.ttf in Resources */, | ||
B339FF1A289ABD70001B89FB /* Roboto-Light.ttf in Resources */, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,28 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<Scheme | ||
LastUpgradeVersion = "1340" | ||
version = "1.3"> | ||
version = "1.7"> | ||
<BuildAction | ||
parallelizeBuildables = "YES" | ||
buildImplicitDependencies = "YES"> | ||
<PreActions> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of having the copy scripts in Xcode scripts, we could probably copy the files in |
||
<ExecutionAction | ||
ActionType = "Xcode.IDEStandardExecutionActionsCore.ExecutionActionType.ShellScriptAction"> | ||
<ActionContent | ||
title = "Run Script" | ||
scriptText = "cp ${SRCROOT}/GoogleServices/GoogleService-Info.plist ${SRCROOT}/GoogleService-Info.plist "> | ||
<EnvironmentBuildable> | ||
<BuildableReference | ||
BuildableIdentifier = "primary" | ||
BlueprintIdentifier = "B339FEF8289ABD70001B89FB" | ||
BuildableName = "MetaMask-QA.app" | ||
BlueprintName = "MetaMask-QA" | ||
ReferencedContainer = "container:MetaMask.xcodeproj"> | ||
</BuildableReference> | ||
</EnvironmentBuildable> | ||
</ActionContent> | ||
</ExecutionAction> | ||
</PreActions> | ||
<BuildActionEntries> | ||
<BuildActionEntry | ||
buildForTesting = "YES" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
#import <Firebase.h> | ||
#import <React/RCTBridgeDelegate.h> | ||
#import <UIKit/UIKit.h> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand this correctly?
GOOGLE_SERVICES_B64_ANDROID
is used for android builds and not for ios buildsGOOGLE_SERVICES_B64_IOS
is used for ios builds and not for android buildsIf so, wouldn't it be better to keep letting the build system handle this by keeping the single
GOOGLE_SERVICES_B64
, instead of having the dev manage 2 separate env vars?