Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reject connection properly #11314

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat: reject connection properly #11314

merged 5 commits into from
Sep 19, 2024

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Sep 19, 2024

Description

This PR is an update to the SDK communication protocol that allows the following:

  • prevent deleting connection until server confirmation
  • emit rejection event

Related issues

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s abretonc7s requested review from a team as code owners September 19, 2024 08:26
@abretonc7s abretonc7s self-assigned this Sep 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added the team-sdk SDK team label Sep 19, 2024
@abretonc7s abretonc7s marked this pull request as draft September 19, 2024 08:27
Copy link

socket-security bot commented Sep 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] environment 0 3.27 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@abretonc7s abretonc7s marked this pull request as ready for review September 19, 2024 12:31
@abretonc7s abretonc7s requested review from a team as code owners September 19, 2024 12:31
Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Sep 19, 2024

@abretonc7s abretonc7s added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 19, 2024
@abretonc7s abretonc7s added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 6fc1d9d Sep 19, 2024
42 of 43 checks passed
@abretonc7s abretonc7s deleted the sdk-protocol-update branch September 19, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants