Add support for rpcUrl with basic auth when retrieving chainId on net… #9815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
rekmarks
reviewed
Nov 6, 2020
rekmarks
requested changes
Nov 6, 2020
There was a problem hiding this comment.
Thank you for creating this PR.
Can you please confirm that my suggestion works and merge it? It will fix the lint failure.
It would also be helpful if you allowed edits from maintainers.
|
thanks @rekmarks for the review and suggested updates, I merged the changes and made a small update after testing the function inside browser console. |
Gudahtt
requested changes
Nov 6, 2020
|
@rekmarks for some reason I couldn't find the "Allow edits by maintainers" checkbox anymore which used to be under the "Participants" section 🤔 |
Gudahtt
reviewed
Nov 6, 2020
Gudahtt
reviewed
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…work creation
Fixes: #9791
Explanation: This new function to retrieve chainId on network creation does not take into account that
rpcUrlmay contain basic auth:https://<username>:<password>@permissioned.network. Fix adds checking for the basic auth in the URL and adds basic auth to the header and adjust the rpcUrl passed towindow.fetch()Manual testing steps:
https://<username>:<password>@permissioned.network(exact value dependent on the permissioned network)Could not fetch chain ID. Is your RPC URL correct?