Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom RPC network dropdown icons #9764

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Update custom RPC network dropdown icons #9764

merged 2 commits into from
Oct 30, 2020

Conversation

rekmarks
Copy link
Member

This updates the network dropdown icons for custom RPC networks to something less unsightly. Item from design review.

Before
After

@rekmarks rekmarks requested a review from rachelcope October 30, 2020 04:43
@rekmarks rekmarks requested a review from a team as a code owner October 30, 2020 04:43
@rekmarks rekmarks requested a review from whymarrh October 30, 2020 04:43
@metamaskbot
Copy link
Collaborator

Builds ready [e9df9cc]
Page Load Metrics (363 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308239147
domContentLoaded24660136110651
load24760336310751
domInteractive24560136010651

@darkwing darkwing self-requested a review October 30, 2020 14:20
darkwing
darkwing approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Nice work!

rachelcope
rachelcope approved these changes Oct 30, 2020
View reviewed changes
Copy link

@rachelcope rachelcope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved! 🦖

@rekmarks rekmarks merged commit ca7df8d into develop Oct 30, 2020
@rekmarks rekmarks deleted the network-dropdown-custom-network-icons branch October 30, 2020 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelcope rachelcope rachelcope approved these changes

@darkwing darkwing darkwing approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @metamaskbot @darkwing @rachelcope