Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize app component font styles #9695

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

brad-decker
Copy link
Contributor

depends on #9693

This PR is a piece of the larger #9074 PR. The recent rebase to include the swaps feature puts it into a state of needing full review once again. To minimize the pain and to keep the conversation on the PR from being too broad I have split it into a handful of smaller PRs. This PR focuses on App components which are not as broadly used as UI components.

@metamaskbot
Copy link
Collaborator

Builds ready [1f9816a]
Page Load Metrics (440 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298039115
domContentLoaded24680643814067
load24780744014167
domInteractive24580643814067

Base automatically changed from expose-typography-vars to develop October 28, 2020 14:03
@brad-decker brad-decker marked this pull request as ready for review October 28, 2020 14:04
@brad-decker brad-decker requested a review from a team as a code owner October 28, 2020 14:04
@brad-decker brad-decker requested a review from danfinlay October 28, 2020 14:04
height: 41px;
@include Paragraph;

min-height: 41px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

darkwing
darkwing previously approved these changes Oct 28, 2020
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@brad-decker brad-decker requested review from Gudahtt and removed request for danfinlay October 28, 2020 15:54
@Gudahtt
Copy link
Member

Gudahtt commented Oct 29, 2020

LGTM! Except it needs a rebase.

@metamaskbot
Copy link
Collaborator

Builds ready [26c213a]
Page Load Metrics (432 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint299740178
domContentLoaded24166743115173
load24266943215173
domInteractive24066643115173

@brad-decker brad-decker merged commit fe69182 into develop Oct 29, 2020
@brad-decker brad-decker deleted the normalize-app-component-fonts branch October 29, 2020 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants