Add messages for MetaMetrics opt-in #9283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whymarrh I goofed but everything should be working now. |
rekmarks
force-pushed
the
metamatrics-messages
branch
from
85109ee to
c195d63
Compare
whymarrh
approved these changes
Aug 20, 2020
Builds ready [c195d63]
Page Load Metrics (484 ± 77 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the MetaMetrics opt-in page has inconsistent capitalization. When fixing it, I also noticed that the button text values were inlined for the relevant components. This PR applies consistent capitalization for the buttons and converts their values to locale messages.