do not show amounts for approvals #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
commented
Jul 17, 2020
| "alertSettingsUnconnectedAccount": { | ||
| "message": "Browsing a website with an unconnected account selected" | ||
| }, | ||
| "alertSettingsUnconnectedAccountDescription": { |
Builds ready [5455ebb]
Page Load Metrics (606 ± 34 ms)
|
whymarrh
suggested changes
Jul 20, 2020
Builds ready [df85746]
Page Load Metrics (648 ± 27 ms)
|
Gudahtt
reviewed
Jul 21, 2020
Gudahtt
requested changes
Jul 21, 2020
| @@ -106,7 +106,7 @@ export function useTransactionDisplayData (transactionGroup) { | |||
| subtitleContainsOrigin = true | |||
| } else if (transactionCategory === TOKEN_METHOD_APPROVE) { | |||
| category = TRANSACTION_CATEGORY_APPROVAL | |||
| title = t('approve') | |||
| title = t('approve', [token?.symbol || t('token')]) | |||
There was a problem hiding this comment.
Oh, actually, we shouldn't do this. approve is used elsewhere as a key where no substitution will ever be passed in (e.g. confirm-transaction-base.component, where transactionCategory is passed to t(..)).
We should leave the old "Approve" message there and preserve the translations, but add a new message for this particular case.
There was a problem hiding this comment.
Thanks @Gudahtt. Pushed up a resolution for this
Builds ready [f0837eb]
Page Load Metrics (619 ± 61 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For conversation see: https://consensys.slack.com/archives/GTQAGKY5V/p1595014477062700