Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display pending notifications after connect flow #9011

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 16, 2020

The notification window is now kept open after the connect flow if there are still pending confirmations. Previously, the notification
window would be closed after the connect flow no matter what, and any pending confirmations would never be shown to the user.

This was accomplished by redirecting to the home screen after the connect flow. The logic for deciding whether or not to close the window is already handled by the home page. This does have the unfortunate side-effect of briefly rendering the home page before the window closes, but this is a minor problem that exists already in a number of other scenarios, and it will be fixed in a subsequent PR.

Fixes #8973

The notification window is now kept open after the connect flow if
there are still pending confirmations. Previously, the notification
window would be closed after the connect flow no matter what, and any
pending confirmations would never be shown to the user.

This was accomplished by redirecting to the home screen after the
connect flow. The logic for deciding whether or not to close the window
is already handled by the home page. This does have the unfortunate
side-effect of briefly rendering the home page before the window
closes, but this is a minor problem that exists already in a number of
other scenarios, and it will be fixed in a subsequent PR.

Fixes #8973
@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 16, 2020

This does have the unfortunate side-effect of briefly rendering the home page before the window closes, but this is a minor problem that exists already in a number of other scenarios, and it will be fixed in a subsequent PR.

This has been addressed in #9012

@metamaskbot
Copy link
Collaborator

Builds ready [606ffb6]
Page Load Metrics (556 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint288036147
domContentLoaded3116375539546
load3156395569345
domInteractive3106375539546

@Gudahtt Gudahtt marked this pull request as ready for review July 16, 2020 04:34
@Gudahtt Gudahtt requested a review from a team as a code owner July 16, 2020 04:34
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9012 is way better than what I had done here 👍

@Gudahtt Gudahtt merged commit b97cd1d into develop Jul 16, 2020
@Gudahtt Gudahtt deleted the keep-notification-open-after-connect-if-confirmations-pending branch July 16, 2020 12:13
@metamaskbot metamaskbot mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup does not appear in chained request
3 participants