Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide loading indication after personal_sign #9006

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Hide loading indication after personal_sign #9006

merged 1 commit into from
Jul 16, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 15, 2020

The loading indication had remained after successfully signing with personal_sign. This mistake was introduced accidentally in #8434.

This is noticeable if you confirm the signature in the popup UI or fullscreen UI, as they remain open after signing. The notification UI
closes after signing without waiting for this loading indicator to be removed.

@Gudahtt
Hide loading indication after personal_sign
5dfafc2 
The loading indication had remained after successfully signing with
`personal_sign`. This mistake was introduced accidentally in #8434.

This is noticeable if you confirm the signature in the popup UI or
fullscreen UI, as they remain open after signing. The notification UI
closes after signing without waiting for this loading indicator to be
removed.
@Gudahtt Gudahtt requested a review from a team as a code owner July 15, 2020 22:01
@metamaskbot
Copy link
Collaborator

Builds ready [5dfafc2]
Page Load Metrics (643 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308545189
domContentLoaded5947336413517
load5967356433517
domInteractive5947336413517

rekmarks
rekmarks approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 7333d82 into develop Jul 16, 2020
@Gudahtt Gudahtt deleted the hide-loading-indication-after-personal-message-sign branch July 16, 2020 01:12
@Gudahtt Gudahtt mentioned this pull request Jul 16, 2020
Closed
@metamaskbot metamaskbot mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @rekmarks