Add lock images to static repo. #9
Merged
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the ui in one project but the static resources in this one is a good sign that either: - We should have the UI in this project. - We should find a way to keep the static resources in the UI repo.
|
yeah you are correct - this is a bit of a pain point. lets think about the best flow here. maybe breaking it out into its own react module and then doing some preprocessomg to inline the file makes the most sense... |
kumavis
added a commit
that referenced
this pull request
Mar 3, 2016
Add lock images to static repo.
kumavis
added a commit
that referenced
this pull request
Feb 3, 2017
kumavis
added a commit
that referenced
this pull request
Feb 3, 2017
meppsilon
pushed a commit
to meppsilon/metamask-extension
that referenced
this pull request
Dec 1, 2021
Send and dismiss stx error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the ui in one project but the static resources in this one is a good sign that either:
Sorry that they're pngs. They should be svgs, but Pixelmator apparently doesn't support svg export and I didn't realize until I'd already made this nice lock as a proof of concept.