Include relative time polyfill locale data #8896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
include-relative-time-polyfill-for-all-locales
branch
2 times, most recently
from
3913b5c to
c44413e
Compare
Builds ready [c44413e]
Page Load Metrics (641 ± 15 ms)
|
We were including the polyfill for the `Intl.RelativeTimeFormat` API, but we weren't including any locale data. This polyfill doesn't work without the locale data for whichever locale you're formatting. The data for all locales we support is now included. The locale data is loaded from disk as-needed (during app startup, and upon each change in locale).
Gudahtt
force-pushed
the
include-relative-time-polyfill-for-all-locales
branch
from
c44413e to
75fd1a1
Compare
Gudahtt
changed the title
|
This has been tested to work on Firefox v60.0, which is the same version we saw the Sentry error report from. I've tested it with the |
Builds ready [75fd1a1]
Page Load Metrics (1055 ± 55 ms)
|
|
For reference, this API was introduced in #8774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were including the polyfill for the
Intl.RelativeTimeFormatAPI, but we weren't including any locale data. This polyfill doesn't work without the locale data for whichever locale you're formatting.The data for all locales we support is now included. The locale data is loaded from disk as-needed (during app startup, and upon each change in locale).