-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn users to only add custom networks that they trust #8789
Conversation
cc: @jakehaugen |
Builds ready [1d7ebf4]
Page Load Metrics (583 ± 16 ms)
|
7d0cafb
to
1d7ebf4
Compare
Builds ready [1d7ebf4]
Page Load Metrics (648 ± 39 ms)
|
I'm not sure about the copy; "record your on-chain activity" is decidedly innocuous, since on-chain activity is public anyway. This goes beyond recording on-chain activity. The RPC endpoint would see all messages, many of which don't result in on-chain activity. It would also see your IP address, letting it correlate activity from different accounts sharing the same IP. I'm not sure how to best word this, but those seem like the real threats to me - not on-chain activity. I'll see if I can think of an alternate wording. |
@Gudahtt, yeah, it's a bit thorny because I doubt most users have any idea of the kinds of network activity going on. How about "record your Ethereum-related activity"? Or "Ethereum-related network traffic"? I was thinking about "read" instead of "record" also, but I'm concerned users might take it to imply that they can read private data. Edit: Where we define "private" as e.g., your keys or something. |
The RPC endpoint could also lie about the current state of the blockchain. That could be used to do sneaky things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [2103d50]
Page Load Metrics (697 ± 32 ms)
|
Adds a warning to the custom RPC form warning users to only add networks that they trust.
Copy is up for debate. Currently:
Also gives the poor settings page sub-header some breathing room via top/bottom padding. It's only used in the custom RPC form.
Fixes #8667
Screenshot (old copy)