Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use UI button for add token functionality #8781

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Jun 10, 2020

Replaces the "missing your tokens? Add Token" text/button with a UI Button that matches the "View More" button styling on the transaction list. Open for revision.

Screenshot

@metamaskbot
Copy link
Collaborator

Builds ready [4d749d3]
Page Load Metrics (704 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint307738105
domContentLoaded6148477016129
load6308497046029
domInteractive6138467016129

@brad-decker brad-decker marked this pull request as ready for review June 10, 2020 21:50
@brad-decker brad-decker requested a review from a team as a code owner June 10, 2020 21:50
@rekmarks
Copy link
Member

Got any screeny bois?

@brad-decker
Copy link
Contributor Author

Got any screeny bois?

Added to description @rekmarks thanks for reminding me.

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 73ba992 into develop Jun 12, 2020
@brad-decker brad-decker deleted the add-token-button branch June 12, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants