Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broaden usage options for list-item #8587

Merged
merged 2 commits into from
May 13, 2020
Merged

broaden usage options for list-item #8587

merged 2 commits into from
May 13, 2020

Conversation

brad-decker
Copy link
Contributor

As part of my work on #8564, I needed to make some changes to the list-item, and in discussion with @Gudahtt, we decided to broaden the list-item UI component to be more general purpose. This is the resulting component, with updated .stories to show how it is intended to be used to display transaction data.

@brad-decker brad-decker requested a review from a team as a code owner May 13, 2020 16:10
@brad-decker brad-decker requested a review from Gudahtt May 13, 2020 16:10
@metamaskbot
Copy link
Collaborator

Builds ready [a7f288f]
Page Load Metrics (644 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3310546189
domContentLoaded38580764214168
load38780964414168
domInteractive38580764214168

Gudahtt
Gudahtt previously approved these changes May 13, 2020
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ui/app/components/ui/list-item/index.scss Outdated Show resolved Hide resolved
ui/app/components/ui/list-item/list-item.component.js Outdated Show resolved Hide resolved
@brad-decker brad-decker force-pushed the refactor-list-item branch from 601d04a to 7027b9f Compare May 13, 2020 20:30
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [7027b9f]
Page Load Metrics (626 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30463752
domContentLoaded33983262411354
load34083462611354
domInteractive33883262411354

@brad-decker brad-decker merged commit 7327212 into develop May 13, 2020
@whymarrh whymarrh deleted the refactor-list-item branch June 8, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants