fixes firefox popup location #8467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
suggested changes
Apr 29, 2020
Co-Authored-By: Whymarrh Whitby <[email protected]>
brad-decker
force-pushed
the
firefox-modal-positioning
branch
from
8f42ab8 to
6b872e3
Compare
|
Changed that up, @whymarrh, thanks for the suggestion |
Gudahtt
approved these changes
Apr 29, 2020
Builds ready [6b872e3]
Page Load Metrics (642 ± 42 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that firefox doesn't have the proper popup location, but that's because firefox doesn't respect top and left on
windows.create. https://bugzilla.mozilla.org/show_bug.cgi?id=1271047It does, however, respect
windows.update. This PR adds a method for moving the popup window ifpopupWindow.left !== left. Has a flash of the popup opening wherever firefox says it should, but ends up in the right place.