Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Dai/Sai migration notification #8418

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

whymarrh
Copy link
Contributor

Closes #8376

This PR removes the DAI/SAI migration notification, as the window for migrations has now closed. This PR effectively undoes #7450 and #7475.

@whymarrh whymarrh force-pushed the dai-sai-migration branch 2 times, most recently from 07f6df8 to 52ecf39 Compare April 27, 2020 17:06
@whymarrh whymarrh force-pushed the dai-sai-migration branch from 52ecf39 to a8b42c7 Compare April 27, 2020 17:13
@whymarrh whymarrh marked this pull request as ready for review April 27, 2020 17:50
@whymarrh whymarrh requested a review from a team as a code owner April 27, 2020 17:50
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit eb06394 into MetaMask:develop Apr 27, 2020
@whymarrh whymarrh deleted the dai-sai-migration branch April 27, 2020 18:53
Gudahtt pushed a commit that referenced this pull request Apr 28, 2020
This backports the deletion of the Dai/Sai migration notification
(#8418). Note that the migration to delete the now unused background
state has not been included, as it is non-essential and would have been
more difficult to backport. The migration to delete the unused state
will be included in the next major release instead.
Gudahtt pushed a commit that referenced this pull request Apr 29, 2020
This backports the deletion of the Dai/Sai migration notification
(#8418). Note that the migration to delete the now unused background
state has not been included, as it is non-essential and would have been
more difficult to backport. The migration to delete the unused state
will be included in the next major release instead.
Gudahtt added a commit that referenced this pull request Apr 29, 2020
This backports the deletion of the Dai/Sai migration notification
(#8418). Note that the migration to delete the now unused background
state has not been included, as it is non-essential and would have been
more difficult to backport. The migration to delete the unused state
will be included in the next major release instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SAI=>DAI conversion suggestion feature
2 participants