Skip adding history entry for empty txMeta diffs #8379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
reviewed
Apr 22, 2020
whymarrh
force-pushed
the
tx-empty-history-entries
branch
from
c83a7aa to
00eac75
Compare
Gudahtt
approved these changes
Apr 22, 2020
kumavis
approved these changes
Apr 22, 2020
Gudahtt
pushed a commit
that referenced
this pull request
Apr 28, 2020
Gudahtt
pushed a commit
that referenced
this pull request
Apr 29, 2020
Gudahtt
added a commit
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
TransactionStateManagerupdate logic to skip adding a history entry when the diff is empty.As shown in #8377, there are cases when
updateTxis called without a diff in the metadata. Both on v7.7.8 and here ondevelop, thetxMeta.historycan contain empty arrays. This isn't useful behaviour, as the history is used for debugging and an empty entry doesn't provide any information.