Add Idle Timeout for Sync with mobile #8201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
changed the title
Gudahtt
previously approved these changes
Mar 24, 2020
| @@ -47,27 +48,45 @@ export default class MobileSyncPage extends Component { | |||
| } | |||
| } | |||
|
|
|||
| handleIdleTimeout () { | |||
There was a problem hiding this comment.
Maybe startIdleTimeout would be a better name? "handle" makes me thing this is an event handler or something.
Gudahtt
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user opens up the "Sync with mobile" section and enters their password they're presented with a QR code that can be scanned. At this point the end user is vulnerable to anybody else that can see the aforementioned QR code...
My thinking with adding this is that it's just an additional safety mechanism. If a user opens this area and somehow forgets (gets distracted, walks away from their computer leaving it unlocked) this mechanism will ensure the amount of time the QR code is displayed on the screen is limited.