Clean up list of available currencies #7667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
pushed a commit
that referenced
this pull request
Apr 29, 2020
This is backported to make it easier to backport #7986
Gudahtt
added a commit
that referenced
this pull request
Apr 29, 2020
This is backported to make it easier to backport #7986 Co-authored-by: Whymarrh Whitby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a bit of prep work for #5976.)
This PR cleans up how we store and use our list of available currencies/conversions (exposed through the settings page option). We no longer use Infura for conversions so the variable and file naming was stale. I've also taking this opportunity to trim down the JSON file we use to list out the set of available conversions, removing unused properties.