Correct the zh-TW translation #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Thanks @SiriusTsou !
@MetaMask/translators could anybody help review this? These changes look good to me, but I was using Google Translate 😅
gasolin
suggested changes
Oct 24, 2019
| @@ -162,7 +162,7 @@ | |||
| "description": "helper for inputting hex as decimal input" | |||
| }, | |||
| "blockExplorerUrl": { | |||
| "message": "封鎖 Explorer" | |||
| "message": "區塊鏈瀏覽器" | |||
There was a problem hiding this comment.
The new translation is better reflecting the actual meaning :D
to align with following translations, better to translate this string as 區塊鏈瀏覽器 URL
There was a problem hiding this comment.
@gasolin You can review the EN locale file in app/_locales/en/message.json, the original message is Block Explorer instead of Block Explorer Url, so my translation may be much appropriate.
gasolin
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Zh-TW translations are quite different from the true meaning in traditional Chinese.