Fix custom nonce placeholder type #7243
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hmm, I guess it's not set in the initial render. I'll leave the placeholder unset if |
The placeholder for the custom nonce needed to be converted into a string. The placeholder is omitted if `nextNonce` isn't set, as may be the case for the initial render.
Gudahtt
force-pushed
the
fix-custom-nonce-placeholder-type
branch
from
b5bd55e to
67bb0f8
Compare
tmashuang
approved these changes
Oct 2, 2019
Builds ready [67bb0f8]
|
danjm
approved these changes
Oct 2, 2019
danjm
pushed a commit
that referenced
this pull request
Oct 2, 2019
The placeholder for the custom nonce needed to be converted into a string. The placeholder is omitted if `nextNonce` isn't set, as may be the case for the initial render.
JohnnyJumper
pushed a commit
to unstoppabledomains/metamask-extension
that referenced
this pull request
Oct 6, 2019
The placeholder for the custom nonce needed to be converted into a string. The placeholder is omitted if `nextNonce` isn't set, as may be the case for the initial render.
Gudahtt
added a commit
that referenced
this pull request
Oct 9, 2019
The placeholder for the custom nonce needed to be converted into a string. The placeholder is omitted if `nextNonce` isn't set, as may be the case for the initial render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholder for the custom nonce needed to be converted into a string.