build - replace gulp-uglify-es with gulp-terser-js #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests passed with a retry for e2e-chrome |
|
actually they both already use |
Gudahtt
requested changes
Sep 10, 2019
Gudahtt
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Looks good!
I'm surprised there isn't a more popular library - neither this nor the one it's replacing seem popular. I wonder what other projects are using for this kinda thing.
Ah well, as long as it works. It's just a gulp wrapper around terser so I guess it can't be that complicated.
|
tried out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to the build script.
terseris a maintained continuation ofuglify-es. This has negligible impact on the build.side note: for
sourcemap-validatorreplacingterserdid not solve the issue I was having withuglify-es