Update publishing doc to reflect automation #6899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
release-script-docs
branch
from
d8d3f23 to
c03f1f1
Compare
Gudahtt
reviewed
Jul 23, 2019
There was a problem hiding this comment.
Perhaps it would be better to say "main branch" or "develop" instead of "latest commit pending release"? It's not clear to me what "latest commit pending release" means - in a sense, none of the commits are "pending release" until after the release branch has been created.
Gudahtt
previously approved these changes
Jul 24, 2019
whymarrh
force-pushed
the
release-script-docs
branch
from
c2fc8c0 to
5737508
Compare
Gudahtt
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised,[1] this PR updates the publishing guide to reflect the changes to the workflow now that some automation is in place (#6653). I've left out the automatic creation of the release here on GH since that's not a process that involves a human.