Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes invalid prop error, correctly types nextRoute #6761

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fixes invalid prop error, correctly types nextRoute #6761

merged 1 commit into from
Jun 27, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jun 27, 2019

Fixes: #6760

Changes nextRoute type from PropTypes.func -> PropTypes.string

cc: @danfinlay @whymarrh

@ryanml ryanml requested review from danjm and whymarrh as code owners June 27, 2019 01:06
Gudahtt
Gudahtt approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fantastic, I was just about to look into this.

Looks good, thanks!

@ryanml
Copy link
Contributor Author

ryanml commented Jun 27, 2019

Thanks @Gudahtt !

whymarrh
whymarrh approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryanml!

@whymarrh whymarrh merged commit 59d3a3d into MetaMask:develop Jun 27, 2019
@danfinlay danfinlay mentioned this pull request Jul 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid prop error during onboarding flow
3 participants
@ryanml @whymarrh @Gudahtt