Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seed phrase import back button #6758

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 26, 2019

The back button on the import seed phrase page leaves the Redux store with appState.forgottenPassword set to true, which prevents the user from logging in. That flag is now unset when the user leaves the page.

Fixes #6740

The back button on the import seed phrase page leaves the Redux store
with `appState.forgottenPassword` set to true, which prevents the user
from logging in. That flag is now unset when the user leaves the page.

Fixes MetaMask#6740
@Gudahtt Gudahtt requested a review from danjm June 26, 2019 20:07
@Gudahtt Gudahtt requested a review from whymarrh as a code owner June 26, 2019 20:07
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 27, 2019

I'm going to update this PR to add a few unit tests

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 27, 2019

Nevermind; I'll put that in a separate PR. It requires a bit more effort than I had first thought, such as refactoring into .component.js and .container.js

@Gudahtt Gudahtt merged commit a6bfc6f into MetaMask:develop Jun 27, 2019
@Gudahtt Gudahtt deleted the i6740-fix-seed-phrase-import-back-button branch July 5, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going back from seed phrase import prevents log in
2 participants