Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: reject enable promise on user rejection #6671

Merged
merged 1 commit into from
May 31, 2019
Merged

bugfix: reject enable promise on user rejection #6671

merged 1 commit into from
May 31, 2019

Conversation

bitpshr
Copy link
Contributor

@bitpshr bitpshr commented May 31, 2019

This pull request checks for both types of possible RPC errors (the error argument and result.error) and rejects the Promise returned by ethereum.enable accordingly.

Fixes #6631

@metamaskbot
Copy link
Collaborator

Builds ready [e8f6dff]: chrome, firefox, edge, opera

@bitpshr bitpshr requested a review from jennypollack May 31, 2019 20:28
@danfinlay danfinlay merged commit b600a4f into develop May 31, 2019
@bitpshr bitpshr deleted the bugfix/enable-rejection branch May 31, 2019 21:07
@danfinlay danfinlay mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@kumavis kumavis Awaiting requested review from kumavis

@whymarrh whymarrh Awaiting requested review from whymarrh

@danjm danjm Awaiting requested review from danjm

@frankiebee frankiebee Awaiting requested review from frankiebee

@tmashuang tmashuang Awaiting requested review from tmashuang

@jennypollack jennypollack Awaiting requested review from jennypollack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ethereum.enable() doesn't throw when user rejects popup.
3 participants
@bitpshr @metamaskbot @danfinlay