Add simple send e2e test #6669
Merged
Add simple send e2e test #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
e2e-simple-send
branch
2 times, most recently
from
20fb03a to
69fb1f5
Compare
whymarrh
force-pushed
the
e2e-simple-send
branch
from
69fb1f5 to
4a9c5cb
Compare
|
@danjm this is ready for review—I've added it to CI but I'm still debugging it. It does pass locally so maybe we can leave out the CI job for now? |
|
@whymarrh I agree we can leave out the CI for now. |
|
Can you add some basic documentation for running these tests locally? |
|
Do we need to commit all of these fixture files/ |
danjm
requested changes
Jun 24, 2019
whymarrh
force-pushed
the
e2e-simple-send
branch
from
da163e5 to
de52680
Compare
Whatever is needed for a test to run should be committed to the repo, yes. It's the best solution I can come up with, but I'm open to alternatives.
I've added brief info for running the tests locally and for generating the fixture files. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6548
This PR adds a e2e test using fixture data that exercises the send flow, sending 1 ETH from one account to another on a local test chain.