Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include token checksum address in prices lookup for token rates #6526

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Include token checksum address in prices lookup for token rates #6526

merged 1 commit into from
Apr 30, 2019

Conversation

tmashuang
Copy link
Contributor

Fixes #6506 root issue, not checking checksum token address from CoinGecko response.

@metamaskbot
Copy link
Collaborator

Builds ready [67f3fc1]: chrome, firefox, edge, opera

whymarrh
whymarrh approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd unfortunate that CoinGecko would be inconsistent with their addresses in their responses but this is a safe branch to add.

@whymarrh whymarrh merged commit c7492f4 into develop Apr 30, 2019
@whymarrh whymarrh deleted the token-rates-address-issue branch April 30, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6.4 -No price conversions available for some tokens - NMR, WETH
3 participants
@tmashuang @metamaskbot @whymarrh