Ensure home screen does not render if there are unapproved txs #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e are unapproved txs.
|
LGTM 🔥 - i will review + approve again when tests pass |
danjm
force-pushed
the
render-confirm-before-home
branch
from
0e95fa4 to
3bc2cda
Compare
chikeichan
approved these changes
Apr 25, 2019
kumavis
pushed a commit
that referenced
this pull request
Apr 29, 2019
* Ensure that the confirm screen renders before the home screen if there are unapproved txs. * Only render confirm screen before home screen on mount.
Gudahtt
added a commit
that referenced
this pull request
Feb 28, 2020
The Home screen had a check for whether the current path is `/confirm-transaction`, but the router wouldn't have routed there if that was the case. This was done in #6501 as a performance improvement, but I suspect this line in particular never worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing significantly slow behaviour when transaction lists are large. I will add more details to this description later.
This was discovered while working on #6380. Resolving that issue will lead to further performance improvements on the confirm screen, in some cases.
@bdresser This will fix performance problems that have the same symptoms as what some users describe in #6017