Fixes #6321 & #6421 - Add Localhost 8545 for network dropdown names #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmashuang
changed the title
danjm
approved these changes
Apr 16, 2019
|
@tmashuang This looks good to me. Merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the UI bug associate with #6321. There still is an issue when setting Custom RPCs, which keeps the
rpcTarget/nicknamein the provider params even when switching off to one of the default networks. Evidently, this clears thetickeras well, which could be #6421 issue as well.Latest commit should fix #6421, and initial commit fixes #6321.