Metrics updates

[danjm]

Fixes #6370

Included updates/fixes:
Track seed phrase validation errors with MetaMetrics 4963ed6
Metrics tracking gas changed - slow, average, fast, custom - on edit screnn 5454266
Distinguish between token and eth selected in home screen send button metrics event 5d94836
Only pass english function names to functionType metric f7e3ba2

[whymarrh]

I don't quite understand the impetus for f7e3ba2—there are still branches where the action contains a translated string and, separately, it doesn't seem immediately obvious that that the action is a key, not a full string (should we name it actionKey?)

Can you share a bit more context for that commit?

[danjm]

Good question @whymarrh

The impetus for f7e3ba2 is to ensure that the functionType custom variable passed to metricsEvent is set to a non-translated key.

You can see where this happens here:
https://github.com/MetaMask/metamask-extension/blob/f7e3ba2a403279788182ce8f03fb9b8fa7f066a1/ui/app/pages/confirm-transaction-base/confirm-transaction-base.component.js#L172
https://github.com/MetaMask/metamask-extension/blob/f7e3ba2a403279788182ce8f03fb9b8fa7f066a1/ui/app/pages/confirm-transaction-base/confirm-transaction-base.component.js#L305
https://github.com/MetaMask/metamask-extension/blob/f7e3ba2a403279788182ce8f03fb9b8fa7f066a1/ui/app/pages/confirm-transaction-base/confirm-transaction-base.component.js#L345
https://github.com/MetaMask/metamask-extension/blob/f7e3ba2a403279788182ce8f03fb9b8fa7f066a1/ui/app/pages/confirm-transaction-base/confirm-transaction-base.component.js#L380

[metamaskbot]

Builds ready [10b256f]: chrome, firefox, edge, opera

[metamaskbot]

Builds ready [c80b295]: chrome, firefox, edge, opera

[whymarrh]

LGTM