Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notice controller #6382

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Remove notice controller #6382

merged 4 commits into from
Apr 2, 2019

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Apr 1, 2019 •
edited
Loading

Removes notice controller and associated code, and adds migration to delete in storage.

@tmashuang tmashuang requested review from danjm and whymarrh as code owners April 1, 2019 16:58
@metamaskbot
Copy link
Collaborator

Builds ready [bdaef99]: chrome, firefox, edge, opera

whymarrh
whymarrh approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@whymarrh whymarrh merged commit a46ec83 into develop Apr 2, 2019
@whymarrh whymarrh deleted the remove-notice-controller branch May 22, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @metamaskbot @whymarrh