Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent add duplicates when address is not new #6372

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Conversation

jennypollack
Copy link
Contributor

we store the existing accounts all lowercase, which causes duplicated adds of existing accounts to the new address book

kumavis
kumavis previously approved these changes Mar 29, 2019
Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennypollack looks good! made a small change

@metamaskbot
Copy link
Collaborator

Builds ready [0961449]: chrome, firefox, edge, opera

@kumavis kumavis merged commit 133ed80 into develop Mar 29, 2019
@kumavis kumavis deleted the addAddressIfNew branch March 29, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants