Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mobile sync #6332

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Enable mobile sync #6332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cb5898
enable mobile sync
brunobar79 Mar 21, 2019
516dedd
remove mobile sync as a preference
brunobar79 Mar 21, 2019
4b7d8c8
Fix typo
brunobar79 Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/secret-preferences.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ One example is our "sync with mobile" feature, which didn't make sense to roll o

To enable features like this, first open the background console, and then you can use the global method `global.setPreference(key, value)`.

For example, if the feature flag was a booelan was called `mobileSync`, you might type `setPreference('mobileSync', true)`.
For example, if the feature flag was a boolean was called `useNativeCurrencyAsPrimaryCurrency`, you might type `setPreference('useNativeCurrencyAsPrimaryCurrency', true)`.

7 changes: 1 addition & 6 deletions ui/app/components/pages/settings/settings-tab/settings-tab.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export default class SettingsTab extends PureComponent {
setUseNativeCurrencyAsPrimaryCurrencyPreference: PropTypes.func,
setAdvancedInlineGasFeatureFlag: PropTypes.func,
advancedInlineGas: PropTypes.bool,
mobileSync: PropTypes.bool,
showFiatInTestnets: PropTypes.bool,
setShowFiatConversionOnTestnetsPreference: PropTypes.func.isRequired,
participateInMetaMetrics: PropTypes.bool,
Expand Down Expand Up @@ -378,11 +377,7 @@ export default class SettingsTab extends PureComponent {

renderMobileSync () {
const { t } = this.context
const { history, mobileSync } = this.props

if (!mobileSync) {
return
}
const { history } = this.props

return (
<div className="settings-page__content-row">
Expand Down
2 changes: 0 additions & 2 deletions ui/app/components/pages/settings/settings-tab/settings-tab.container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const mapStateToProps = state => {
sendHexData,
privacyMode,
advancedInlineGas,
mobileSync,
} = {},
provider = {},
currentLocale,
Expand All @@ -48,7 +47,6 @@ const mapStateToProps = state => {
privacyMode,
provider,
useNativeCurrencyAsPrimaryCurrency,
mobileSync,
showFiatInTestnets,
participateInMetaMetrics,
}
Expand Down