Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer check network when validating checksum addresses #6280

Merged
merged 2 commits into from
Mar 11, 2019
Merged

No longer check network when validating checksum addresses #6280

merged 2 commits into from
Mar 11, 2019

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Mar 11, 2019 •
edited
Loading

Comment out network checking on validating checksum address.
Fixes #6214

whymarrh
whymarrh suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete the lines instead of commenting them out, we can view the old versions if we need to reference the old implementations

@metamaskbot
Copy link
Collaborator

Builds ready [22c4fe0]: mascara, chrome, firefox, edge, opera

@tmashuang tmashuang requested a review from whymarrh March 11, 2019 18:38
@metamaskbot
Copy link
Collaborator

Builds ready [ef7ac90]: mascara, chrome, firefox, edge, opera

@tmashuang tmashuang merged commit c44f785 into develop Mar 11, 2019
@tmashuang tmashuang deleted the network-checksum-disable branch March 11, 2019 21:53
@jonathansmirnoff jonathansmirnoff mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @metamaskbot @whymarrh