Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonmultiple notifications for batch txs #6279

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Nonmultiple notifications for batch txs #6279

merged 1 commit into from
Mar 11, 2019

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Mar 11, 2019 •
edited
Loading

Fixes #6264
Fixes #6273

Will no longer bring the notification to the foreground, but will no longer create multiple notifications for batch txs.

@metamaskbot
Copy link
Collaborator

Builds ready [43f5fd0]: mascara, chrome, firefox, edge, opera

@whymarrh whymarrh requested a review from danjm March 11, 2019 18:20
whymarrh
whymarrh approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmashuang tmashuang merged commit 59dbb9b into develop Mar 11, 2019
@tmashuang tmashuang deleted the notification-window branch March 11, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @metamaskbot @whymarrh