Allow seed phrases with a trailing newline #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
approved these changes
Feb 27, 2019
danjm
reviewed
Feb 27, 2019
| @@ -45,9 +45,11 @@ export default class ImportWithSeedPhrase extends PureComponent { | |||
| } else if (!validateMnemonic(parsedSeedPhrase)) { | |||
| seedPhraseError = this.context.t('invalidSeedPhrase') | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Test failures are real failures. parsedSeedPhrase will always remove trailing white spaces, not allowing the user to type spaced words.
There was a problem hiding this comment.
Yeah totally didn't test this
|
Updated. |
|
@whymarrh looks like conflicts popped up again |
whymarrh
force-pushed
the
seed-phrase-newline
branch
from
4c08918 to
1c9caa4
Compare
whymarrh
force-pushed
the
seed-phrase-newline
branch
from
1c9caa4 to
29a0b34
Compare
danjm
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6134 and #5827
Take 3 🎬
This PR updates the import seed phrase screen (during on-boarding) to strip extraneous leading and trailing whitespace from the seed phrase. This adds the crucial step of using the trimmed seed phrase in the
onSubmithandler.