Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inpage.js event handler memory leak #6177

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix inpage.js event handler memory leak #6177

merged 1 commit into from
Feb 18, 2019

Conversation

gkaemmer
Copy link
Contributor

Fixes #6176

Confirmed that this properly works:

getEventListeners(window).message.length
// => 3
ethereum._metamask.isApproved()

getEventListeners(window).message.length
// => Still 3

@bdresser bdresser requested a review from bitpshr February 18, 2019 20:35
@bitpshr bitpshr merged commit 89c4353 into MetaMask:develop Feb 18, 2019
@bitpshr
Copy link
Contributor

bitpshr commented Feb 18, 2019

Thanks for this @gkaemmer!

@danfinlay danfinlay mentioned this pull request Feb 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitpshr bitpshr bitpshr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkaemmer @bitpshr