Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check balance before showing cancel #6088

Closed
wants to merge 4 commits into from
Closed

Check balance before showing cancel #6088

wants to merge 4 commits into from

Conversation

chikeichan
Copy link
Contributor

@chikeichan chikeichan commented Feb 1, 2019 •
edited
Loading

This PR adds a check to make sure that selectedAccount has enough balance to cover gas fee for cancel transaction. If selectedAccountBalance is less than the gas fee for canceling, it will not render the cancel button.

fixes #5927

@chikeichan
Copy link
Contributor Author

cancel

  • rebased and cherry-picked the e2e test fixed
  • implemented the disabled button and tooltip as per your comment, @danjm

@danjm danjm mentioned this pull request Mar 25, 2019
Merged
@danjm danjm closed this in #6341 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel Transaction modal needs to handle insufficient balance error
2 participants
@chikeichan @danjm