Disable account dropdown on signing screens #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
suggested changes
Jan 16, 2019
|
|
||
| export default class AccountDropdownMini extends PureComponent { | ||
| static propTypes = { | ||
| accounts: PropTypes.array, |
There was a problem hiding this comment.
We might be able to add .isRequired to this prop
| dropdownOpen: PropTypes.bool, | ||
| onSelect: PropTypes.func, | ||
| openDropdown: PropTypes.func, | ||
| selectedAccount: PropTypes.object, |
There was a problem hiding this comment.
We might be able to add .isRequired to this prop
alextsg
force-pushed
the
i6014-disable-accounts
branch
from
889540f to
5bac208
Compare
alextsg
force-pushed
the
i6014-disable-accounts
branch
from
5bac208 to
0a018c7
Compare
whymarrh
approved these changes
Jan 16, 2019
Gudahtt
added a commit
to Gudahtt/metamask-extension
that referenced
this pull request
Jul 24, 2019
The `AccountDropdownMini` component featured the ability to switch accounts using a dropdown, but this functionality was disabled in MetaMask#6024. It has been acting as a restyled `AccountListItem` since then. The component has been removed, and the style changes moved to the sole parent component (`RequestSignature`).
Gudahtt
added a commit
that referenced
this pull request
Jul 25, 2019
The `AccountDropdownMini` component featured the ability to switch accounts using a dropdown, but this functionality was disabled in #6024. It has been acting as a restyled `AccountListItem` since then. The component has been removed, and the style changes moved to the sole parent component (`RequestSignature`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6014