Add scrolling button to account list #5957
Closed
+398
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
suggested changes
Dec 20, 2018
| renderKeyringType (keyring) { | ||
| const { t } = this.context | ||
|
|
||
| try { // Sometimes keyrings aren't loaded yet: |
There was a problem hiding this comment.
In the case where keyrings aren't loaded, what exception are we catching here? Can we instead have a default for type or return null if !keyring.type?
There was a problem hiding this comment.
I'm not really sure what the try catch is for as I just copied this over from the original code, but yeah, we should be able to remove this.
alextsg
force-pushed
the
i5140-accounts
branch
from
b42a666 to
77db81b
Compare
|
@alextsg looks great! I've slacked you the SVG icon, and also including a direct link to download https://www.dropbox.com/s/j1swxdzxacpowb2/down_arrow.svg?dl=0 |
alextsg
force-pushed
the
i5140-accounts
branch
2 times, most recently
from
884d36e to
0d1e4c5
Compare
alextsg
force-pushed
the
i5140-accounts
branch
from
0d1e4c5 to
0b4469b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5140
@cjeria I'm using a placeholder arrow icon that we currently have and just rotated it, but it doesn't exactly match what's in the mock. Once I get the icon from you I'll update this PR.