Add visual indicator when displaying a cached balance. #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
cf2db0f to
f4cc41c
Compare
danjm
force-pushed
the
ui-indication-cached-balance
branch
from
8044c97 to
db93403
Compare
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
f4cc41c to
cd179e8
Compare
danjm
force-pushed
the
ui-indication-cached-balance
branch
from
db93403 to
64770c0
Compare
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
cd179e8 to
efa04db
Compare
danjm
force-pushed
the
ui-indication-cached-balance
branch
3 times, most recently
from
3c3546a to
e8878fe
Compare
danjm
force-pushed
the
ui-indication-cached-balance
branch
from
e8878fe to
36d9f74
Compare
danjm
changed the base branch from
cache-network-balances-local-storage
to
develop
danjm
force-pushed
the
ui-indication-cached-balance
branch
2 times, most recently
from
946d942 to
896fa3d
Compare
whymarrh
suggested changes
Jan 24, 2019
ui/app/components/index.scss
Outdated
| @@ -75,3 +75,5 @@ | |||
| @import './gas-customization/index'; | |||
|
|
|||
| @import './gas-customization/gas-price-button-group/index'; | |||
|
|
|||
| // @import './send/account-list-item/account-list-item/index'; | |||
danjm
force-pushed
the
ui-indication-cached-balance
branch
from
896fa3d to
45a1680
Compare
whymarrh
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branches off of #5843
This adds an asterix next to balances to indicate to the user that the displayed balances may be cached.
@cjeria Does this look okay to you? The scenario is that the user is being shown a balance that might be slightly outdated (i.e. a small number of blocks old). The user would be shown this balance because of connectivity issues. We are deciding here that it is better to show an outdated balance than nothing or a zero balance.
Also ccing @bahnju as I imagine we will also start consulting you on this sort of stuff soon