Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node version to 8.13 #5810

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Bump Node version to 8.13 #5810

merged 2 commits into from
Nov 21, 2018

Conversation

whymarrh
Copy link
Contributor

This PR bumps the Node version for nvm to 8.13 which now includes npm@6 (where 8.11.3 included npm@5). I've also updated the docs.

@whymarrh whymarrh requested a review from brunobar79 November 21, 2018 19:22
brunobar79
brunobar79 previously approved these changes Nov 21, 2018
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one optional comment

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯!

@whymarrh whymarrh merged commit 804b273 into MetaMask:develop Nov 21, 2018
@whymarrh whymarrh deleted the bump-nvmrc branch November 21, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants