transactions - ensure err is defined when setting tx failed #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
reviewed
Nov 21, 2018
| @@ -361,13 +361,15 @@ class TransactionStateManager extends EventEmitter { | |||
| @param err {erroObject} - error object | |||
| */ | |||
| setTxStatusFailed (txId, err) { | |||
| let error = !err ? Error('Internal metamask failure') : err | |||
There was a problem hiding this comment.
shouldn't be new Error('Internal metamask failure') ?
There was a problem hiding this comment.
Also the linter is failing because it wants a const instead of let
frankiebee
force-pushed
the
fail-first-tx
branch
from
309d183 to
c581f50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so @brunobar79 instead of what we discussed i did this so that we dont mess with sentry logs because they need the error before the fail event which is fired during the status change